Turbofish operator for try_parse #68
Merged
+82
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Build is failing. I probably did not include all the dependant commits after all. You can consider this PR as a draft for the moment |
n4r1b
reviewed
Nov 11, 2022
README.md
Outdated
| - [Shaddy](https://github.com/Shaddy) for, pretty much, teaching me all the Rust I know 😃 | ||
| - [n4r1b](https://github.com/n4r1b) for creating this great crate | ||
| - [daladim](https://github.com/daladim) for adding even more features |
|
This is beautiful! I was really looking forward to doing this change, thank you very much @daladim 😄🥳. Feel free to merge when ready! |
daladim
force-pushed
the
turbofish_try_parse
branch
2 times, most recently
from
db05a70 to
9d03ce5
Compare
That removes the following TODO: // TODO: Find a way to use turbofish operator
daladim
force-pushed
the
turbofish_try_parse
branch
from
9d03ce5 to
477cbfb
Compare
|
I've rebased to fix the git conflict, without changing anything really. I'm merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #63 and #65 , as its first commits come from them.
This makes it possible to use the turbofish operator for
try_parse, which is slightly more convenient than the current solution.This improvement was already considered by @n4r1b quite a long time ago, since there was a
// TODO: Find a way to use turbofish operator